Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the way results are parsed so we want fail to parse non-string result types #175

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

KevinCLydon
Copy link
Member

The way it worked before, it assumed all values in the result json from cromwell would be of the type String. Now, instead, we get the value as its type and convert it to a string.

Fixes #174

Copy link
Collaborator

@jonn-smith jonn-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KevinCLydon KevinCLydon merged commit 2b23713 into master Mar 1, 2022
@KevinCLydon KevinCLydon deleted the kl_numeric_results_failure_174 branch March 1, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing numeric results fails
2 participants